New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fix argument type in `Cache\Store` #51100

Merged

taylorotwell merged 1 commit into laravel:11.x from GromNaN:cache-store-type

Apr 17, 2024

Contributor

GromNaN commented Apr 17, 2024 •

edited

The cache stores only accept a string for the $key parameter, an array produces an error. This type was introduced by bbd825b without details.

The methods increment/decrement can leverage the type false that is more precise than bool.


          Fix $key type in Cache\Store

35319bb

GromNaN force-pushed the cache-store-type branch from 5d2ff3c to 35319bb Compare

April 17, 2024 14:01

taylorotwell merged commit 33e3c47 into laravel:11.x

28 checks passed

GromNaN deleted the cache-store-type branch

April 17, 2024 14:22

GromNaN changed the title ~~Fix argument type in Cache\Store~~ [11.x] Fix argument type in Cache\Store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment