Fixes the required_if messages if multiple values are passed #5262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added test to check required_if with multiple values moved the test to proper method
taylorotwell
added a commit
that referenced
this pull request
Sep 8, 2014
Fixes the required_if messages if multiple values are passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed the previous pull request #5260. This contains the rebased code.
When passing in multiple values in
required_if(like so:required_if:type,mobile,email) for a attribute in rules, then the error message always showed errors with the first value ('mobile' in this case) replaced in the message string. This was due to the following code inIlluminate\Validation\Validatorline1799:But, error can be generated by any value in the rule (by 'mobile' or by 'email'). This pull request fixes the problem and also adds a test to verify the same.