[4.2] Remove % From filenameFallback In Response::download #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it's not allowed in the fallback name. (See https://github.com/symfony/symfony/blob/v2.5.5/src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php#L264-L277)
GrahamCampbell
changed the title
|
👍 |
taylorotwell
added a commit
that referenced
this pull request
Dec 17, 2014
[4.2] Remove % From filenameFallback In Response::download
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filename fallback is turned to ASCII, because only ASCII is allowed. But there are 2 more checks:
%in the fallback(See https://github.com/symfony/symfony/blob/v2.5.5/src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php#L264-L277)
I think we can skip the slashes, because they are also checked in the filename itself. But we should probably remove the % sign. Downloads work when files have a
%in them, just the fallback doesn't.I propose removing the % from the fallback.