Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature for installing Mailpit and disabling Mailhog #1864

Merged
merged 2 commits into from Mar 10, 2023

Conversation

Sn0wCrack
Copy link
Contributor

@Sn0wCrack Sn0wCrack commented Mar 6, 2023

Resolves #1860

This just uses the install script provided on mailpit's repository which will download the correct binary based on the OS and Architecture you're running, it supports arm64 so should work fine on Apple Silicon devices.

It will also disable mailhog's systemd service, however the mailhog binary will remain installed on the system if the user wishes to switch back.

Copy link
Collaborator

@svpernova09 svpernova09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@svpernova09 svpernova09 merged commit 5cc9510 into laravel:main Mar 10, 2023
3 checks passed
@litan1106
Copy link
Contributor

@Sn0wCrack I love this feature approach. People can still use mailhog as default but can opt-in mailpit with features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Mailpit integration
3 participants