Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dev Support to Network settings #1897

Merged

Conversation

ALameLlama
Copy link
Contributor

Currently trying to set a network interface when you don't have an eth0 will cause it to fail.

[root@homestead testing-homestead]# vagrant up
Bringing machine 'testing-homestead' up with 'libvirt' provider...
There are errors in the configuration of this machine. Please fix
the following errors and try again:

Libvirt Provider:
* network configuration 2 for machine testing-homestead is a public_network referencing host device 'eth0' which does not exist, consider adding ':dev => ....' referencing one of enp2s0

This allow passing a dev e.g:

networks:
    - type: "public_network"
      ip: "192.168.1.72"
      bridge: "enp2s0"
      dev: "enp2s0"

@ALameLlama
Copy link
Contributor Author

If we've happy with this, I can also update the docs

@svpernova09 svpernova09 merged commit 236edc3 into laravel:main Oct 16, 2023
4 checks passed
@svpernova09
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants