Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly apply editorconfig settings to all yaml files #1951

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

PanisSupraOmnia
Copy link
Contributor

Previously, the editorconfig file contained a section for yaml files, but it only included *.yml files, which meant that it wasn't being used outside of the GitHub Actions config. This PR applies the editorconfig to *.yml, *.yaml, and *.yaml.example, and applies the correct indentation to those yaml files.

@svpernova09
Copy link
Contributor

Thanks for the PR

@simonschaufi
Copy link

simonschaufi commented Apr 24, 2024

why is this not merged yet?

@svpernova09
Copy link
Contributor

why is this not merged yet?

There's a lot in the pipeline and I've not had the time to dedicate to sit down and go through it all properly yet.

@svpernova09 svpernova09 merged commit 8e6b057 into laravel:main Apr 27, 2024
4 checks passed
@PanisSupraOmnia PanisSupraOmnia deleted the fix/yaml-formatting branch April 27, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants