Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Update syntax highlighting #1002

Merged
merged 1 commit into from
Apr 2, 2021
Merged

[5.x] Update syntax highlighting #1002

merged 1 commit into from
Apr 2, 2021

Conversation

sebdesign
Copy link
Contributor

@sebdesign sebdesign commented Apr 2, 2021

It seems that the vue-json-pretty library has been updated a while ago and the syntax highlighting broke.

This PR updates the styles according to https://github.com/leezng/vue-json-pretty/blob/v1.7.1/src/assets/less/tree.less and laravel/telescope#721

Before:

vue-json-pretty-broken

After

vue-json-pretty-fixed

@driesvints
Copy link
Member

@sebdesign heya. Can you undo the asset compilation? (see the contributing docs). And fix the StyleCI issues?

@driesvints driesvints changed the title Update syntax highlighting [5.x] Update syntax highlighting Apr 2, 2021
@sebdesign
Copy link
Contributor Author

@driesvints I've force-pushed the changes that you asked.

@taylorotwell taylorotwell merged commit e5bc161 into laravel:5.x Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants