Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when register, keep the original redis options, only overwrite prefix #1161

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

nthsky
Copy link
Contributor

@nthsky nthsky commented Jul 7, 2022

current:
when register, the origin redis option is overwritten, leaving only the prefix.

expect:
keep the origin redis option, only overwrite prefix

explanation:
when using redis sentinel with predis driver, the config is like:

        'default' => [
            'redis-sentinel:26379',
            'options' => [
                'replication' => 'sentinel',
                'service' => 'mymaster',
                'parameters' => [
                    'password' => 'xxxxxx',
                    'database' => 0,
                ],
            ]
        ]

the current situation: when using horizon, the sentinel option will be overwritten and cannot create connection correctly. And it will throw exception like:

ERR unknown command 'ZADD', with args beginning with: 'laravel_horizon:recent_jobs' '-1657159739.0121' 'a6ea2c53-565b-4f1b-927c-f5f1d2b8af34'

It's expected that the original option is preserved then the sentinel is connect correctly.

@taylorotwell taylorotwell merged commit 93f5d74 into laravel:5.x Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants