Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Failed job list: Modify job retry tooltip label to include status of last job retry #1182

Conversation

Jevz
Copy link
Contributor

@Jevz Jevz commented Sep 2, 2022

Hi,

I hope you are doing well.

At the moment the only way to see if a retried job has been completed is to either:

  • Navigate to the job detail view
  • By checking if a job with the "retried" label still has the retry spinner button or not (not very obvious or self-evident in my opinion)

I believe adding the last job retry status to the failed job tooltip would add value, since it would show the status explicitly without needing any further page navigation.

Jeandre van Zyl and others added 5 commits September 2, 2022 12:18
…tatus of last retry

- Simplified logic by removing unnecessary checks, since when method is called there will always have been a retry
@taylorotwell taylorotwell merged commit 3db6568 into laravel:5.x Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants