[5.x] Silenced jobs #1232
Merged
[5.x] Silenced jobs #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1230
This PR introduces the concept of "silenced" jobs. If a certain job class is added to the
horizon.silencedlist then it'll go into a separate storage key and they can then be viewed on a separate screen from other jobs that are completed. This is handy to exclude jobs which are run very frequently likePingOhDearJob.One thing I couldn't solve was to set the "Completed Jobs" menu item to active when you're on the "Silenced Jobs" screen.
Resolves #1153