Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation errors for PHP 8.2 #1270

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

AntonCooper
Copy link
Contributor

Horizon is throwing some deprecation errors for PHP 8.2 as a null value is being passed to str_replace

This PR fixes this issue and corrects the docblocks for allowing a null value to be passed in as the time.

str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in vendor/laravel/horizon/src/Repositories/RedisMetricsRepository.php on line 201
str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in vendor/laravel/horizon/src/Repositories/RedisMetricsRepository.php on line 187

@taylorotwell taylorotwell merged commit 952c2a0 into laravel:5.x Apr 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants