[5.x] Throws Laravel\Horizon\Exceptions\ForbiddenException on unauthorized access
#1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of configurable option I would feel it might be better to throw custom exception and then you can customise how it render via your application Exception Handler. |
|
@crynobone a custom exception would work |
|
I think now we would throw a 500 error? |
crynobone
requested changes
Aug 29, 2023
crynobone
reviewed
Aug 29, 2023
src/Http/Middleware/Authenticate.php
Outdated
| @@ -15,6 +16,10 @@ class Authenticate | |||
| */ | |||
| public function handle($request, $next) | |||
| { | |||
| return Horizon::check($request) ? $next($request) : abort(403); | |||
| if (! Horizon::check($request)) { | |||
| throw new UnauthorizedException(401); | |||
There was a problem hiding this comment.
Any reason not to use 403 same as before?
There was a problem hiding this comment.
I probably pasted the incorrect exception on my last review. Sorry
There was a problem hiding this comment.
Well, the 403 status code !== unauthorized. We can use 403, but we should probably change the name of the exception to use "Forbidden" instead :)
crynobone
changed the title
Laravel\Horizon\Exceptions\ForbiddenException on unauthorized access
crynobone
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common in applications that restrict access to another users' resource to return a 404 to indicate that resource does not exist. I would like to give developers to option to apply this functionality to Horizon to hide it's presence within an application from unauthenticated users.
This PR allows developers to define what status code should be returned when Horizon's authentication fails, via a new
horizon.unauthorized_statusconfig option (happy for this to be renamed, if anyone has any other suggestions).I've restricted the accepted status codes to 403 and 404, falling back to 403 if this is not the case.