[5.x] feature: this adds the vite integrity plugin to support assetsAreCurrent check #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmachatschek
commented
Apr 13, 2024
Comment on lines
+3
to
+13
| use Illuminate\Foundation\Vite as ViteFoundation; | ||
|
|
||
| $viteDataSchemeLight = new ViteFoundation(); | ||
| $viteDataSchemeLight->useStyleTagAttributes([ | ||
| 'data-scheme' => 'light', | ||
| ]); | ||
|
|
||
| $viteDataSchemeDark = new ViteFoundation(); | ||
| $viteDataSchemeDark->useStyleTagAttributes([ | ||
| 'data-scheme' => 'dark', | ||
| ]); |
There was a problem hiding this comment.
if there is a better solution to this please tell me. currently its fairly hard (impossible) to add these kind of style tag attributes with the @Vite blade directive
…ent check fix schema -> scheme compile assets
mmachatschek
force-pushed
the
add_integrity_plugin
branch
from
e440755
to
0cc7e2a
Compare
driesvints
reviewed
Apr 15, 2024
|
@mmachatschek what would they see if the assets aren't up to date? I also thought we already had a check for this 🤔 |
|
@driesvints there is a file compare check here Line 195 in 3c6661d with laravel mix we used versioning that added a hash horizon/public/mix-manifest.json Line 2 in 32ca28d the integrity package readds this missing feature after my change from mix to vite |
driesvints
approved these changes
Apr 15, 2024
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the manifest integrity plugin for vite to support checks if the user published the current version of the horizon assets.