Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Adding horizon:status command #545

Merged
merged 2 commits into from
Mar 8, 2019

Conversation

dbpolito
Copy link
Contributor

@dbpolito dbpolito commented Mar 7, 2019

Adding horizon:status command to be able to check via cli the status of Horizon.

@driesvints
Copy link
Member

@dbpolito I believe this is for #468 ?

It's always better to be very thorough in your PR description so it has a higher chance of being accepted.

@dbpolito
Copy link
Contributor Author

dbpolito commented Mar 7, 2019

Yes, that's my use case, this will solve the problem too. Sorry, i didn't look for related tickets. I agree that would be better.

@driesvints
Copy link
Member

The addition of public function currentStatus(); on the MasterSupervisorRepository interface is a breaking change in this release. I think it might be better if we add this in the next one. Didn't check this on the previous PR, sorry.

@dbpolito
Copy link
Contributor Author

dbpolito commented Mar 7, 2019

Well, this is not required. I can duplicate the logic on the command for now so we can have it. It will be definitely useful to people, not sure this has to wait a new version.

I did that to reuse the logic.

@driesvints
Copy link
Member

Yeah, that might be better for now.

@dbpolito
Copy link
Contributor Author

dbpolito commented Mar 7, 2019

Done

@taylorotwell taylorotwell merged commit 3dc26eb into laravel:3.0 Mar 8, 2019
@driesvints
Copy link
Member

@dbpolito I've merged this into master. You can send the changes you did at first there if you want.

@dbpolito dbpolito deleted the horizon_status branch March 8, 2019 15:16
@delmicio
Copy link

delmicio commented Sep 5, 2020

@dbpolito How can I use it programmatically without Artisan::call function?

@dbpolito
Copy link
Contributor Author

dbpolito commented Sep 5, 2020

@delmicio that depends on your use case or what you want to do... in my case i'm using as readiness/livinessProbe on kubernetes with bash script

@delmicio
Copy link

delmicio commented Sep 5, 2020

@dbpolito I see there is a protected function called currentStatus on this PR. Any chance to do what that function does on a laravel controller for example?

@delmicio
Copy link

delmicio commented Sep 5, 2020

found it on another package if some is interested:
https://github.com/antonioribeiro/health/blob/master/src/Checkers/Horizon.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants