Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Do not override all options provided by connection #960

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

edvinaskrucas
Copy link

By default when horizon redis connection is created in config it flushes all of extra options. By doing this we are not able to use redis sentinel configuration via predis driver. This PR merges default options with ones that are needed for horizon.

#959

@driesvints driesvints changed the title Do not override all options provided by connection [6.x] Do not override all options provided by connection Jan 15, 2021
@taylorotwell
Copy link
Member

And this fix is tested to fix it for your particular application?

@taylorotwell
Copy link
Member

Also, can you share an example of what your Redis configuration looks like?

@edvinaskrucas
Copy link
Author

I am using configuration laid out here laravel/framework#18850 (comment), it works perfectly when not using horizon, as it omits options configuration and overrides it totally with its own when duplicating config group.

@taylorotwell
Copy link
Member

So, yes? Your changes do indeed work perfectly with your own application using Horizon?

@edvinaskrucas
Copy link
Author

Yes, it works as expected.

@taylorotwell taylorotwell merged commit 83d05fa into laravel:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants