Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer doesn't setup scaffolding for inertia ssr when combined by typescript option #277

Closed
Meraik opened this issue Aug 24, 2023 · 1 comment · Fixed by #278
Closed
Labels

Comments

@Meraik
Copy link

Meraik commented Aug 24, 2023

Installer Version

5.0.4

Description

Laravel installer doesn't create ssr.js file nor does it add any of the settings on different config files. This only happens when trying to add other options like typescript or dark mode. It will work as expected when only selecting the ssr option.

Environment:
Windows 10
larave/installer 5.0.4
windows PowerShell & GitBash

Steps To Reproduce

PS E:\web-apps> laravel new ssr-dark

_ _
| | | |
| | __ _ _ __ __ ___ | |
| | / | '__/ _ \ \ / / _ \ |
| |
| (| | | | (| |\ V / / |
|
_,|| _,| _/ ___|_|

Would you like to install a starter kit?:
[none ] No starter kit
[breeze ] Laravel Breeze
[jetstream] Laravel Jetstream

breeze

Which Breeze stack would you like to install?:
[blade] Blade
[react] React with Inertia
[vue ] Vue with Inertia
[api ] API only

react

Would you like any optional features? [None]:
[none ] None
[dark ] Dark mode
[ssr ] Inertia SSR
[typescript] TypeScript (experimental)

dark, ssr

Which testing framework do you prefer?:
[0] PHPUnit
[1] Pest

1

@Meraik
Copy link
Author

Meraik commented Aug 24, 2023

If I create new project with no starter kit and then install breeze with ssr, typescript options together then all files and settings are created as expected

@crynobone crynobone added the bug label Aug 24, 2023
crynobone added a commit that referenced this issue Aug 24, 2023
fixes #277

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@jessarcher jessarcher assigned jessarcher and unassigned jessarcher Aug 25, 2023
driesvints pushed a commit that referenced this issue Aug 25, 2023
fixes #277

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants