Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of the two factor challenge with an empty recovery code input #1299

Closed
wants to merge 1 commit into from

Conversation

sebastiansulinski
Copy link

@sebastiansulinski sebastiansulinski commented Apr 18, 2023

Description

This PR together with the one I've submitted to laravel/fortify is providing the fix for the following scenario:


While authenticating with 2FA using the code option with empty input, on submission we get the validation message:

Screenshot 2023-04-15 at 12 10 44

however when doing the same using recovery code option - we do not see the error:

Screenshot 2023-04-15 at 12 12 06

Steps To Reproduce

Authenticate using username and password, followed by 2FA form - first try the code and then recovery code - both times submit form with empty input.

Only code version will display validation message.

@taylorotwell
Copy link
Member

Your component name has a spelling error?

@sebastiansulinski
Copy link
Author

@taylorotwell - ups, didn't realise - that's now been updated and new PR submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants