Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Allow Inertia pages paths modification #1494

Closed

Conversation

mho22
Copy link

@mho22 mho22 commented May 19, 2024

Based on the issue #1491. @driesvints suggested to create a PR about this.

Currently it is not possible to modify the paths of Inertia pages like :

api : API/Index
profile : Profile/Show
teams : Teams/Create and Teams/Show

Based on the logic used in Fortify, I proposed to apply methods on the Jetstream class to enable the modification of the rendering behavior for these views.

Fortify logic :

Fortify::loginView(function () {
    return Inertia::render('Auth/Login', [
        'canResetPassword' => Route::has('password.request'),
        'status' => session('status'),
    ]);
});

New methods from Jetstream class :

Jetstream::apiIndexView( ... )
Jetstream::profileShowView( ... )
Jetstream::teamsCreateView( ... )
Jetstream::teamsShowView( ... )

A JetstreamServiceProviderTest file has been created based on FortifyServiceProviderTest.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants