Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Rename path to prefix for route config #504

Merged
merged 3 commits into from
Dec 2, 2020
Merged

[1.x] Rename path to prefix for route config #504

merged 3 commits into from
Dec 2, 2020

Conversation

unlikenesses
Copy link
Contributor

This changes the config key used to determine the prefix for Jetstream routes from path to prefix. This keeps it consistent with the same config key used in Fortify (see https://github.com/laravel/fortify/blob/1.x/src/FortifyServiceProvider.php#L128).

@driesvints
Copy link
Member

This is a breaking change on a stable branch. Best to be sent to master.

@driesvints driesvints changed the title Rename path to prefix for route config [1.x] Rename path to prefix for route config Dec 1, 2020
@taylorotwell
Copy link
Member

You can make it not breaking by supporting both - using one as a fallback to the other.

@unlikenesses
Copy link
Contributor Author

You can make it not breaking by supporting both - using one as a fallback to the other.

I've made it fall back to path.

@taylorotwell taylorotwell merged commit e675d5f into laravel:1.x Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants