Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the <code> tag overflow on mobile resolution #153

Merged
merged 2 commits into from Jan 8, 2021

Conversation

timothepearce
Copy link
Contributor

@timothepearce timothepearce commented Jan 8, 2021

Issue

The <code> tag causes a horizontal scroll on mobile devices when its content is too long (eg: Sanctum documentation page). See the screenshot above:
horizontal-scroll

Fix

I added CSS attributes to the tag being careful not to break the alignment with the rest of the textual content.

@driesvints
Copy link
Member

Maybe post a screenshot of the issue.

@taylorotwell taylorotwell merged commit 7bb0a37 into laravel:master Jan 8, 2021
@vlakoff
Copy link
Contributor

vlakoff commented May 31, 2021

Do you remember why you replaced the previous display: inline-block with inline-flex?

@timothepearce
Copy link
Contributor Author

@vlakoff Yes, the text alignment was broken with display: inline-block. Good job for adapting the website layout on mobile btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants