-
Notifications
You must be signed in to change notification settings - Fork 23.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Try a lighter version of the auth scaffolding.
- Loading branch information
1 parent
ce20ef2
commit 359af29
Showing
83 changed files
with
14,595 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
359af29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 So kinda like before just more light weight. Just wondering why from sass to less? Not complaining just wondering.
359af29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same curiosity here. I am under the presumption that Sass is adopted higher in the developer community because of the preprocessing benefits, whereas designers use Less because of the front-end processing requirement. Is it because Bootstrap ships with Less rather than Sass?
359af29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bootstrap has an official sass version as well so maybe it was something else.
359af29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of sass vs less I don't think bootstrap should be included in the repo by default anyway. It would be better imported through bower.
359af29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid, albeit the class names used are following the TWBS names. But I could see the benefit of bug fixes that might roll out in that framework automatically carrying over easier..
359af29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish they just left out the example auth/registration functionality and just provide a basic installation screen with meaningful information, kind of like what rails does.
359af29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guys, the bootstrap is not going to function normally, the Glyphicons are not working because of relative path as well.
359af29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the auth/registration, I'm fine with that.
359af29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taylorotwell why has bootstrap been included like this? any reason not via bower or npm?