Skip to content

Commit

Permalink
set rounds
Browse files Browse the repository at this point in the history
  • Loading branch information
@taylorotwell
taylorotwell committed Dec 19, 2017
1 parent 5a08a35 commit 7b138fe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/CreatesApplication.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public function createApplication()

$app->make(Kernel::class)->bootstrap();

Hash::setRounds(4);
Hash::driver('bcrypt')->setRounds(4);

return $app;
}
Expand Down

4 comments on commit 7b138fe

@hughsaffar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used to improve testing speed, however, after upgrading to Laravel 5.6 the speed improvement is gone. Not sure what I'm missing but in my case the test time jumped to 3 minutes (5.6) from 40 seconds (5.5).

@laurencei
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hughsaffar - did you switch to Argon? Or still using Bcrypt?

@hughsaffar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurencei I tried both and got the same result.

@MichaelDeBoey
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hughsaffar I think it's best to report an issue so @taylorotwell can have a look at it 🙂

Please sign in to comment.