Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Use ComposerScripts #3699

Merged
merged 1 commit into from Mar 25, 2016
Merged

[5.2] Use ComposerScripts #3699

merged 1 commit into from Mar 25, 2016

Conversation

barryvdh
Copy link
Contributor

Use ComposerScripts to avoid loading any configuration/compiled files.

Should probably be done after a new (laravel/framework) version is tagged, to avoid problems with non-existing class..

Use ComposerScripts to avoid loading any configuration/compiled files.
@GrahamCampbell
Copy link
Member

👍

@taylorotwell
Copy link
Member

I'm wondering if it would be safest to tag Laravel framework before merging this in case people clone this repo and then run composer install and get the current tagged version which doesn't have those changes?

@barryvdh
Copy link
Contributor Author

Yeah that's what I meant, a new laravel/framework tag (not laravel/laravel).

@GrahamCampbell GrahamCampbell changed the title Use ComposerScripts [5.2] Use ComposerScripts Mar 23, 2016
@vlakoff
Copy link
Contributor

vlakoff commented Mar 24, 2016

Refs laravel/framework#12827 which is what this PR makes use of.

@barryvdh
Copy link
Contributor Author

I guess, now laravel/framework v5.2.25 is tagged, this can be merged?
Or do you want to back-port to 5.1 first?

@it-can
Copy link

it-can commented Mar 25, 2016

This works perfectly btw, updated my composer.json file :-)

@taylorotwell taylorotwell merged commit 3fc105d into laravel:master Mar 25, 2016
@reavenlin
Copy link

str_replace_array not support for array field ,
"permissions" is a text in "roles" table and it has been set $casts = [ 'permissions'=>'array' ] in Role model , error message:

in helpers.php line 740
at HandleExceptions->handleError('2', 'preg_replace(): Parameter mismatch, pattern is a string while replacement is an array', '/mnt/code/htdocs/xiwo/www/vendor/illuminate/support/helpers.php', '740', array('search' => '?', 'replace' => array('Admin', '1', array('5', '6', '7', '8'), '2016-03-27 08:28:53', '3'), 'subject' => 'update roles set name = Admin, type = 1, permissions = ?, updated_at = ? where id = ?', 'value' => array('5', '6', '7', '8')))
at preg_replace('/?/', array('5', '6', '7', '8'), 'update roles set name = Admin, type = 1, permissions = ?, updated_at = ? where id = ?', '1') in helpers.php line 740
at str_replace_array('?', array('Admin', '1', array('5', '6', '7', '8'), '2016-03-27 08:28:53', '3'), 'update roles set name = ?, type = ?, permissions = ?, updated_at = ? where id = ?') in QueryException.php line 56
at QueryException->formatMessage('update roles set name = ?, type = ?, permissions = ?, updated_at = ? where id = ?', array('Admin', '1', array('5', '6', '7', '8'), '2016-03-27 08:28:53', '3'), object(ErrorException)) in QueryException.php line 39

@vlakoff
Copy link
Contributor

vlakoff commented Mar 27, 2016

Above issue by reavenlin is unrelated, and I'm pretty sure is due to incorrect use of query builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants