Remove the hot file from versionning #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following laravel/framework#17571, I was correctly pointed that the small proposition should be made over here. Here's a copy / past of my message, for clarity's sake. --- When you run `npm run hmr`, a `hot` file is created to the public folder for the `mix()` helper to know if it has to server from the webpack server or not. This file does not go away until we run `npm run dev` (or `watch`). True, if we use `npm run production` in our production server it goes away too, but in case we don't make it go away in development, I don't think it's necessary to version it.
appleboy
added a commit
to appleboy/gitignore
that referenced
this pull request
Jan 27, 2017
bkrukowski
pushed a commit
to bkrukowski/laravel
that referenced
this pull request
Mar 10, 2017
Remove the hot file from versionning
u9E9F
pushed a commit
to u9E9F/gitignore
that referenced
this pull request
Jul 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following laravel/framework#17571, I was correctly pointed that the small proposition should be made over here. Here's a copy / past of my message, for clarity's sake.
When you run
npm run hmr, ahotfile is created to the public folder for themix()helper to know if it has to server from the webpack server or not. This file does not go away until we runnpm run dev(orwatch).True, if we use
npm run productionin our production server it goes away too, but in case we don't make it go away in development, I don't think it's necessary to version it.