Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .env files from versioning #4148

Closed
wants to merge 1 commit into from
Closed

Remove .env files from versioning #4148

wants to merge 1 commit into from

Conversation

m1guelpf
Copy link
Contributor

This change will protect enviroment files like .env.local .env.prooduction .env.remote from versioning

@marky291
Copy link

You are assuming such files will exist.

@m1guelpf
Copy link
Contributor Author

@marky291 It's common to have a .env.production and if some of that files doesn't exist, noting happens.

@frezno
Copy link

frezno commented Feb 20, 2017

imho no need for this.
It's up to the user to add or delete some files which may or may not have an affect on gitignore. But that's up to the user in this case.
Otherwise you might have to add eg a manual.md file and a changelog file etc. as well since those might be added by the user as well.

@thecodemill
Copy link

FYI, whilst not always practical, it's recommended NOT to use .env.production files, or even the .env file itself on production servers. Such config options should be passed to the environment from the server configuration to reduce overhead - https://github.com/vlucas/phpdotenv#usage-notes

@marky291
Copy link

Laravel is built to use .env even for production.

@m1guelpf m1guelpf deleted the patch-1 branch February 20, 2017 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants