-
Notifications
You must be signed in to change notification settings - Fork 23.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.6] Adds nunomaduro/collision on composer require-dev #4514
Conversation
Thanks, but I don't think we should include a third party library like this tbh. |
As this package is "Whoops for the console" I don't see a huge problem (from my cosy little bubble of working with Laravel on small projects over here) with including "Whoops for Http" and "Whoops for console". If anything it makes things more consistent as now we see exceptions in the console like we do in the browser. Otherwise you could just argue that "Whoops" should not be included - but we all love that. I have just started using this and it's awesome. Definitely going to be installing in any future project. |
Laravel 5.5 supports php v7.0 Lines 7 to 8 in 3f0e742
While collision requires php v7.1 |
@ankurk91 Oh, sorry, you're right. |
Seems pretty nice to me. Thanks |
@nunomaduro one thing that I think would be nice is to disable collision when PHPUnit is running. Do you have any thoughts on that? |
@taylorotwell You are right! I just tagged |
Thanks |
This PR proposes the addition of the package Collision as dev dependency of every Laravel app. Collision is an detailed & intuitive error handler framework for PHP console applications, and includes an adapter/service-provider for Laravel.
The package project is https://github.com/nunomaduro/collision and bellow is an screenshot example.
Those are the Collision dependencies:
Concerning the integration Laravel, If the exception implements the
Symfony\Component\Console\Exception\ExceptionInterface
, Collision still uses the default\Illuminate\Contracts\Debug\ExceptionHandler::renderForConsole
method:![screenshot 2017-12-17 22 31 30](https://user-images.githubusercontent.com/5457236/34084031-122b292a-e37a-11e7-96e4-240c8d6bab72.png)
Otherwise Collision will render the exception details itself giving an detailed explanation of the problem:![screenshot 2017-12-17 22 57 56](https://user-images.githubusercontent.com/5457236/34084288-c668d218-e37d-11e7-8d87-07ff733d0a31.png)
If someone needs details about package or about how it works behind the scenes please don't hesitate to ask.