[5.8] Modify RedirectIfAuthenticated middleware to accept multiple guards #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why redirecting an api request? |
|
@gpressutto5 it's just an example , but in real case scenarios we maybe doing this Route::get('admins-only-login-form', 'AdminController@loginForm')->middleware('guest:admin,moderators,users'); |
|
That makes sense, we have already edited this in one of our project for the same reason |
|
Why did you also change the redirect URL? |
|
@taylorotwell sorry changed by mistake |
|
@taylorotwell @Te7a-Houdini Does this break 'guest' middleware? I'm able to access /login on clean 5.8-dev install without redirect... Tested on fresh install, twice. |
tomhorvat
added a commit
to tomhorvat/laravel
that referenced
this pull request
Feb 24, 2019
After laravel#4904 guest middleware should have guard parameter to work as intended
tomhorvat
added a commit
to tomhorvat/laravel
that referenced
this pull request
Feb 24, 2019
After laravel#4904 guest middleware should have guard parameter to work as intended
tomhorvat
added a commit
to tomhorvat/laravel
that referenced
this pull request
Feb 24, 2019
After laravel#4904 guest middleware should have guard parameter to work as intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3685 , this will allows to