Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Default email from name to app name #5178

Merged
merged 1 commit into from Dec 18, 2019
Merged

[6.x] Default email from name to app name #5178

merged 1 commit into from Dec 18, 2019

Conversation

andrewminion-luminfire
Copy link
Contributor

I continually forget to set MAIL_FROM_NAME and IMHO it makes more sense to default to the app name vs. “Example”

@driesvints driesvints changed the title default email from name to app name [6.x] Default email from name to app name Dec 17, 2019
@taylorotwell taylorotwell merged commit c5f9126 into laravel:master Dec 18, 2019
@antonkomarev
Copy link
Contributor

antonkomarev commented Dec 18, 2019 •
edited

Maybe it will be better to add to .env variable MAIL_FROM_NAME="${APP_NAME}"?

By default it will use APP_NAME then variable, but will be overridable.

@antonkomarev antonkomarev mentioned this pull request Dec 18, 2019
Merged
socheatsok78 pushed a commit to pp-spaces/laravel that referenced this pull request Feb 23, 2020
@andrewminion-luminfire @socheatsok78
default email from name to app name (laravel#5178)
8169cec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@andrewminion-luminfire @antonkomarev @taylorotwell