Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Update sanctum config file #5820

Merged
merged 2 commits into from Feb 17, 2022
Merged

[9.x] Update sanctum config file #5820

merged 2 commits into from Feb 17, 2022

Conversation

suyar
Copy link
Contributor

@suyar suyar commented Feb 17, 2022

See sanctum v2.14.1 and this pr #5702317.

@driesvints
Copy link
Member

We'll need to bump sanctum in composer.json to this version as well.

@driesvints driesvints changed the title Update sanctum config file [9.x] Update sanctum config file Feb 17, 2022
@suyar
Copy link
Contributor Author

suyar commented Feb 17, 2022

We'll need to bump sanctum in composer.json to this version as well.

I think this only affects creating new laravel projects, the current sanctum version is "laravel/sanctum": "^2.14", newly created projects will automatically install the latest release.

This configuration was changed in sanctum v2.14.1, I think is fine.

@driesvints
Copy link
Member

If you reference a new public API you always need to make sure that the constraints of a library are resolved in a way that it's always available. I agree probably everything would go fine but if for some bizar reason someone installs 2.14.0 with --prefer-lowest this would break.

@suyar
Copy link
Contributor Author

suyar commented Feb 17, 2022

If you reference a new public API you always need to make sure that the constraints of a library are resolved in a way that it's always available. I agree probably everything would go fine but if for some bizar reason someone installs 2.14.0 with --prefer-lowest this would break.

You are right.

@taylorotwell taylorotwell merged commit 871ff9e into laravel:9.x Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants