Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing nested join clauses #940

Closed

Conversation

vespakoen
Copy link
Contributor

Tested and works, let me know if improvements can be made

Does anyone know why Shawn's commit is showing up in this pull-request?

Signed-off-by: Koen Schmeets k.schmeets@gmail.com

Shawn McCool and others added 3 commits June 25, 2012 13:45
@franzliedke
Copy link
Contributor

Regarding Shawn's commit: Any chance your feature branch was branched off master instead of develop? Trying to merge it back into develop will most likely work, but might show some weird things like that here on GitHub sometimes.

@taylorotwell
Copy link
Member

Hey Vespa, can you give a SQL example of what this allows? Thanks!

@vespakoen
Copy link
Contributor Author

Never mind this pull-request, it doesn't allow anything more than some syntatic sugar, all the things can be accomplished with normal wheres too, so I'll go ahead and close this for you ;)

@vespakoen vespakoen closed this Sep 2, 2012
@franzliedke
Copy link
Contributor

In some cases, there is a small difference between JOIN/ON and WHERE conditions, though.

Read this: http://stackoverflow.com/questions/354070/sql-join-where-clause-vs-on-clause

On Sun, Sep 2, 2012 at 7:56 PM, Koen Schmeets notifications@github.comwrote:

Never mind this pull-request, it doesn't allow anything more than some
syntatic sugar, all the things can be accomplished with normal wheres too,
so I'll go ahead and close this for you ;)


Reply to this email directly or view it on GitHubhttps://github.com//pull/940#issuecomment-8224235.

flap152 pushed a commit to flap152/laravel that referenced this pull request Nov 24, 2017
flap152 pushed a commit to flap152/laravel that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants