Updating resource with attached photos - field is required error

[bradykeeling]

Nova 1.0.8

When I try to update a resource that has an image previously attached to it, it gives an error saying "field is required."

The update form shows the thumbnail of image, but says "no file selected".

I'm able to access the resource image in my views and the file name is stored in the database, so I'm not sure why I am getting these errors. Am I missing something?

Please see screenshots:

[v1nk0]

I guess this is nothing browser related.

The input field seems to stay empty when not overwriting the existing file/image/avatar, so for the validation, the "required" rule is not matched.

[StanBarrows]

@bradykeeling

Did you found a workaround for this problem?

[bradykeeling]

@StanBarrows Not really... I just disabled the "required" rule until a fix is released.

[fukumori]

Try use this closure instead 'required' rule:

function ($attribute, $value, $fail) use ($request) {
    $model = $this->resource->find($request->route('resourceId'));
    if (empty($value) && empty($model->$attribute)) {
        $fail(__(':Attribute is required.', ['attribute' => __($attribute)]));
    }
},

[bradykeeling]

Thanks @lfukumori, I'll give this a go!

Also, what is the purpose of the double underscore "__" before the $attribute variable?

[fukumori]

The $fail() parameter is a fail message. Something like "Field is required.". The function with double underscore __() is for translate this sentence and attribute.

[caseydwyer]

Nova 1.1.4 and somewhat related—I'm also getting this error for Image fields that aren't required, but are submitted empty, regardless of previously attached images/files. Also tried adding sometimes to rules; no dice. Example code:

Image::make('Email Image')
  ->rules('mimes:jpeg,jpg,png')
  ->help('Image used in header of all email messages.'),

Image::make('Social Image')
  ->rules('sometimes', 'mimes:jpeg,jpg,png')
  ->help('Image used in social network preview cards.'),

[ceejayoz]

@dwyer14 I opened a new issue for that; it's a separate thing. #1050

[davidhemphill]

I believe this issue should be fixed. Please post a new issue if the issue persists.