-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save Images: Unhandled Promise Rejection: TypeError #378
Comments
A problem exists if you add the rule "required", because always need to send an image (at least at the moment, same goes for file and avatar field-type) The fact that an image (or file / avatar) is already present does not affect the "required"-rule. In Firefox and Chrome (macOS) this is at least clear as normal validation errors are shown. It seems to be the same error as @StanBarrows gets. Clicking on that errors shows following error-position: And stack trace: -> The Safari error also occurs when the image (or file / avatar) field is not set to "required" by a rule. |
Same problem. Safari on Mac |
Also seeing this problem, Firefox 61.0.2 on a PC. Chrome on a PC is fine. If you select an image you can save the model, but if you edit a model with an existing image, you can't save it. I wasn't able to find a workaround, which is a bit of a problem if you want to use an Image/Avatar field. |
Same with Firefox 62.0 |
The real error is
Triggered in FileField.vue (the |
@AegirLeet did you manage to make a workaround? This problem is making it impossible to use Firefox or Edge (I even believe it only works without problems if you use Chrome) as soon as a File field (this includes Image and Avatar) is on a resource and a new file is not necessarily needed each time you update a record of this resource. Problem still occurs with the latest Nova (v1.0.15) |
@v1nk0 In FileField.vue, look for the
Seems to be working so far. |
@AegirLeet maybe stupid question, but how do I recompile the .js-file of Nova after I made that change in the .vue-file (nova/resources/js/components/Form/FileField.vue) ? |
@v1nk0 Copy the webpack.mix.js.dist to webpack.mix.js and run |
Yes, did that first step. |
I've got this same issue. v1.0.16 |
I'm probably miss something here, but why don't you use creationRules and updateRules ?
|
@DonDiegoAA this issue has nothing to do with the required-rule. |
Ok, I see that on Firefox too now, sorry I should have read better. |
same issue on 1.1 and 1.1.1 on FF |
Yeah - I checked as well. Latest Nova versions 1.1.1 on Firefox - promises error |
Same issue here: (nova version 1.0.19) Avatar field with following details:
is giving the following error on FF: ( Firefox version 62.0 (64-bit) for Ubuntu)
It's working good on Chrome. |
Confirm that the issue still exists in 1.1.3 on Firefox |
The issue still exists in 1.1.3 on Safari too |
The issue still exists in 1.1.4 on Safari and Firefox |
This has been fixed and will be included in an upcoming release. Sorry it took so long! |
@davidhemphill - any chance the next release can be tagged with this fix? |
Is this fix available to use yet? I believe I am using the latest Nova release but I am still seeing this bug. |
@nickpoulos - no unfortunately. It'll be in the "next" release of Nova (ETA unknown) |
Please help, whit this BUG. |
Any news? |
// EDIT: Had a problem with third party field. Done. |
@jboka Thanks, this was our issue as well. |
After that I've created an Object with an Image, I'm not able to update the Model without selecting a new Image. Evena Image is already attached to the Model.
Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'e.t0.response.status')
Safari: Version 11.1.2 (13605.3.8)
The text was updated successfully, but these errors were encountered: