expose the flag to turn on SWOOLE_SSL #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find no PR for this issue #155, so i create this.
Propose to expose SWOOLE_SSL flag and configurable in
config/octane.php.User can just toggle the flag then
sail downandupto turning HTTPS on/off without docker re-build.Since the latest Sail using
php8.0-swoole, Sail PR,User should be able to turn on HTTPS support easily by just editing
Dockerfile&docker-compose.ymlAdding the flag
octane.swoole.enable-openssl&octane.swoole.optionsin the config, so it will not affect default Swoole HTTP setup but easy for user to configure swoole.