Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fix carbon locale when setting it via app locale setter #557

Merged

Conversation

nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Jul 25, 2022

This pull request fixes the last issue regarding the "locale" update on Vapor apps.

So, the first, got fixed here: #552. And it was regarding the any call to "Carbon::setLocale()" actually changing the local for subsequent requests.

The second, is this one, and concerns the fact that "app->setLocale()" is actually setting the locale of the "app" running the server, and not the app handling the request.

As discussed with Carbon's maintainer, we need the releasing of Carbon, before merging and tagging this pull request: briannesbitt/Carbon#2640.

Fixes #551.

PS: Ignore the tests for now, and I will update this, once the Carbon release is ready.

@kylekatarnls
Copy link

briannesbitt/Carbon#2640 released in 2.60.0

@driesvints
Copy link
Member

Thanks @kylekatarnls!

composer.json Outdated Show resolved Hide resolved
@nunomaduro nunomaduro marked this pull request as ready for review July 28, 2022 07:04
@taylorotwell taylorotwell merged commit b96faad into 1.x Jul 28, 2022
@taylorotwell taylorotwell deleted the fix/carbon-locale-when-setting-it-via-app-locale-setter branch July 28, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carbon localization not set via App::setLocale()
4 participants