Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsetting a cookie value when using Swoole #642

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Fix unsetting a cookie value when using Swoole #642

merged 2 commits into from
Feb 3, 2023

Conversation

oprypkhantc
Copy link
Contributor

Closes #641

Following the Symfony's implementation, any empty string or null value will instead use string deleted. To avoid issues with strings like 0 (which are valid cookie values) I'm not using the ?: op.

@taylorotwell taylorotwell merged commit 1013c24 into laravel:1.x Feb 3, 2023
@taylorotwell
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swoole deprecation errors for cookies with null values
2 participants