[2.x] Fix #838: The Symfony VarDumper properly dumps in html context #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
|
No plans to change this at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838
When using
dump(...)for debugging purposes in a request/response context, nothing is displayed in the HTML response.One would expect to see the dumped variable as HTML in the response as is the case with regular Laravel
This one-line fix sets a global parameter that tells the Symfony
VarDumperto always dump as html when we are in the context of a request/response with octane. Without this line theVarDumperwill check PHP_SAPI to determine the context of the variable dump (which is always 'cli' with Octane).Cheers