Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] Use more secure key permissions #1721

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

axlon
Copy link
Contributor

@axlon axlon commented Feb 15, 2024

Passport currently does not check filesystem permissions of the keys it uses, per #454. Passport also doesn't set the correct permissions on the keys it creates.

This PR aims to have Passport use more secure permissions by default, whilst still allowing developers to opt out.

Passport will now:

  • Automatically use stricter permissions when creating keys through the passport:keys command
  • Check key permissions before using them
    • This may be toggled off by setting Passport::$checkKeyPermissions to false
    • This check is disabled on Windows, because it does not support this

@axlon axlon marked this pull request as draft February 15, 2024 12:30
@axlon axlon force-pushed the key-permissions branch 2 times, most recently from 867d3ab to 86397aa Compare February 15, 2024 12:46
@axlon axlon marked this pull request as ready for review February 15, 2024 12:53
@taylorotwell taylorotwell merged commit c97dbf0 into laravel:master Feb 15, 2024
10 checks passed
@axlon axlon deleted the key-permissions branch February 16, 2024 08:40
@hafezdivandari
Copy link
Contributor

The default behavior has been changed on this commit e063df3

Shouldn't we document this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants