Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to ignore no changes for --dirty #140

Merged
merged 3 commits into from
Jan 18, 2023
Merged

add option to ignore no changes for --dirty #140

merged 3 commits into from
Jan 18, 2023

Conversation

joelbutcher
Copy link
Contributor

resolves #139

@nunomaduro
Copy link
Member

We should probably make the --dirty option exit with a status code 0 if there is nothing dirty. @jasonmccreary what do you think?

@joelbutcher
Copy link
Contributor Author

@nunomaduro this PR currently causes things to fall over since the iterator_to_array call throws a logic exception

@joelbutcher
Copy link
Contributor Author

@nunomaduro Fixed the above with a custom exception

@taylorotwell
Copy link
Member

This doesn't need to be a CLI option. It should just exit successfully with 0 exit code if there are no dirty files.

@taylorotwell taylorotwell marked this pull request as draft January 18, 2023 15:01
@joelbutcher joelbutcher marked this pull request as ready for review January 18, 2023 15:30
@joelbutcher
Copy link
Contributor Author

@taylorotwell @nunomaduro ready for re-review

@taylorotwell taylorotwell merged commit fc3c67c into laravel:main Jan 18, 2023
@joelbutcher joelbutcher deleted the fix/ignore-no-changes branch January 18, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New --dirty breaks pre-commit hooks for new commits with non-php code changes
3 participants
@joelbutcher @nunomaduro @taylorotwell