Support Windows paths for --dirty option

[Rigby90]

Currently the --dirty option does not work on Windows, no files are processed regardless of their status within git.

This appears to be caused by the paths being returned by the git status process using different slashes than than those returned from the ConfigurationFactory::finder() which results in the array_intersect returning an empty array.

Git Status Results

C:\...\project-path>git status --short -- *.php
 M app/Models/ModelA.php
 M app/Models/ModelB.php
 M app/Models/ModelC.php

Before Changes

Array of Files from the Git Status Process Output -

array:16 [
  0 => "<project path>\app/Models/ModelA.php"
  1 => "<project path>\app/Models/ModelB.php"
  2 => "<project path>\app/Models/ModelC.php"
	...
]

Array of Files returned by the finder (To show slashes) -

array:10 [
  0 => "<project path>\app\Actions\Fortify\CreateNewUser.php"
  1 => "<project path>\app\Actions\Fortify\PasswordValidationRules.php"
  2 => "<project path>\app\Actions\Fortify\ResetUserPassword.php"
	...
]

Array of intersected values -

[]

After Changes

Array of Files from the Git Status Process Output -

array:16 [
  0 => "<project path>\app\Models\ModelA.php"
  1 => "<project path>\app\Models\ModelB.php"
  2 => "<project path>\app\Models\ModelC.php"
  ...
]

Array of Files returned by the finder -

array:10 [
  0 => "<project path>\app\Actions\Fortify\CreateNewUser.php"
  1 => "<project path>\app\Actions\Fortify\PasswordValidationRules.php"
  2 => "<project path>\app\Actions\Fortify\ResetUserPassword.php"
	...
]

Array of intersected values -

array:16 [
  0 => "<project path>\app\Models\ModelA.php"
  1 => "<project path>\app\Models\ModelB.php"
  2 => "<project path>\app\Models\ModelC.php"
  ...
]

I'm not sold on this solution in terms of whether to change the slashes on the git status result or the results of the finder; however in either case it's a similar fix to one which was achieved in Vapor CLI from several years ago laravel/vapor-cli#10

[nunomaduro]

@Rigby90 Can you pull "dev-main" and check if the issue is now working for you?

[Rigby90]

Appears to be working -

git status --short -- *.php
?? app/Models/ModelA.php

Before -

pint --dirty


  ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Laravel
    PASS   ........................................................................................................................................ 0 files

After -

composer require laravel/pint:dev-main
./composer.json has been updated
Running composer update laravel/pint
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Upgrading laravel/pint (v1.5.0 => dev-main 17d74f9)

...

pint --dirty

  ✓

  ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Laravel
    FIXED   ....................................................................................................................................................................... 1 file, 1 style issue fixed
  ✓ app\Models\ModelA.php                                                                                                                                                                                braces

Thank you!

[nunomaduro]

Great news!