Improve errors on unsupported environments #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error messaging in the following unsupported scenarios:
When running Windows outside of WSL without a fallback. This error should only be seen when using Prompts without a Laravel version that includes [10.x] Prompts framework#46772. Currently, a cryptic error occurs when trying to run the
sttycommand.When the terminal height is less than eight lines the prompts will not render correctly. Traditional terminal standards have a minimum height of 24 lines which is still a common default in modern terminal applications. Still, it's possible to have fewer lines, especially in a terminal "drawer" in an IDE. VSCode's terminal is 11 lines by default, but this can be reduced by increasing the font size or shrinking the drawer height.
Fixes #3
Fixes #8