New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Improve config for 3rd party cards #372

Merged

taylorotwell merged 2 commits into laravel:1.x from timacdonald:groups

May 17, 2024

Member

timacdonald commented May 17, 2024

This PR improves the experience for 3rd party cards that are re-using our traits / features in their own cards.

Traits now utilise the Config facade so that recorders do not need to inject their own config instance – making them more self contained.
Provide defaults for the config values. This is useful if a 3rd party card introduces a feature, such as grouping, but there are apps out there that may not have the config value when they update – because they started on an earlier version.

timacdonald added 2 commits

May 17, 2024 11:51


          Provide fallback when group config is missing

9b40a63


          Improve config for 3rd party cards

963945f

taylorotwell merged commit 37fcc8e into laravel:1.x

18 checks passed

timacdonald deleted the groups branch

May 18, 2024 05:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment