Cleans up deprecated apt-key usage #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no explanation here why this is needed. |
|
Apt-key won't be around next Ubuntu release, but it "works" for now so I suppose the problem can be dealt with during the creation of those containers in a few years. The main reason for this PR is that the advice given by these deprecation warnings to add keys to /etc/apt/trusted.gpg.d/ is not considered best practice. While I don't see cleaning up these warnings as a necessity, I think it is useful simply in preventing people from performing a half-measure and doing the wrong thing based on the advice given by these warnings. Related content: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up deprecated apt-key calling and piping usage through using gpg directly.