Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meilisearch stub to reflect new data path #414

Merged
merged 1 commit into from
May 21, 2022

Conversation

tdondich
Copy link
Contributor

Meilisearch, since v0.27 has updated their working data path to /meili_data. See: https://blog.meilisearch.com/whats-new-in-v0-27/

This fix resolves persistence with images that come after v0.27, including 'latest', which sail uses.

Meilisearch, since v0.27 has updated their working data path to /meili_data. See: https://blog.meilisearch.com/whats-new-in-v0-27/
@AlejandroAkbal
Copy link

Thanks for fixing it, hope it is merged soon!

@taylorotwell taylorotwell merged commit c049316 into laravel:1.x May 21, 2022
@bram-pkg
Copy link
Contributor

Isn't this the second time in a relatively short time, that this has been changed 🤔

@tdondich
Copy link
Contributor Author

I think it’s the price we pay if we utilize the latest tag vs a fixed image tag version. If we utilize a fixed image tag version for this and other images used then we avoid this problem and we can update the versions during sail package version updates with an upgrade guide. Just my two cents. I love sail!

@bram-pkg
Copy link
Contributor

I do agree Sail should use latest tags. It's just a tad annoying that Meilisearch keeps changing it's mind about where to store data :)

@tdondich
Copy link
Contributor Author

I actually think we should fix the image versions to set versions along with each sail release. We do it for mysql and pgsql and others but not for packages like mailhog or meilisearch or selenium. Basically sails expectations may break if one of the dependencies introduce a breaking change in their latest tag. Latest may introduce a major version change just like this one. This change was introduced in a major version update. Shame dockerhub tags don’t simulate semver to better handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants