Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 Support #473

Merged
merged 2 commits into from
Aug 31, 2022
Merged

PHP 8.2 Support #473

merged 2 commits into from
Aug 31, 2022

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Aug 30, 2022

This adds the Dockerfile for PHP 8.2. Default version is still PHP 8.1

@driesvints
Copy link
Member

I feel like this is way too soon. We should only add this once a stable release is out.

@Jubeki
Copy link
Contributor Author

Jubeki commented Aug 30, 2022

True, I will probably only use them for local testing for now.

(RC 1 of PHP 8.2 will be released on 1st September, therefor I thought that would be a good way to test PHP Applications on PHP 8.2 for better bug reporting, though who really would want it could already change the files locally)

@Jubeki
Copy link
Contributor Author

Jubeki commented Aug 30, 2022

@driesvints How about a branch php82 which would allow local testing using composer require laravel/sail:dev-php82?

@driesvints
Copy link
Member

Let's see what Taylor says

@taylorotwell
Copy link
Member

@Jubeki anything broken that you can spot? I know usually memcached is a bit late to the game in terms of being ready for new PHP versions.

@Jubeki
Copy link
Contributor Author

Jubeki commented Aug 30, 2022

Everything seems to work fine for me.
I tested it with one existing and one new laravel application.

Repo: https://github.com/Jubeki/laravel-sail-test-php82

Steps for testing:

git clone git@github.com:Jubeki/laravel-sail-test-php82.git
cd caravel-sail-test-php82
cp .env.example .env
composer install --ignore-platform-reqs
sail up -d
sail composer update --ignore-platform-reqs
sail artisan key:generate
sail php --version
open http://0.0.0.0

@Jubeki
Copy link
Contributor Author

Jubeki commented Aug 30, 2022

@taylorotwell I don't know why, but currently it install php8.2-beta2 instead of php8.2-beta3

I also checked, with apt list php8.2-cli which also returns php8.2-beta2

@taylorotwell taylorotwell merged commit 73030c1 into laravel:1.x Aug 31, 2022
@Jubeki Jubeki deleted the php82-support branch September 13, 2022 13:08
@StefanoMantero
Copy link

Hi all,
I'v tried to build using the 8.2 runtime, but the php-redis is not installed and looking through the Dockerfile i'v found that the php8.2-redis it's actually commented.

Is that intentional ? If yes, why ?

@Jubeki
Copy link
Contributor Author

Jubeki commented Dec 12, 2022

That was intentional, because some extensions are only build after the release of PHP8.2 and could not be installed at that time. It seems like right now only the extension php8.2-pcov is still missing. So I will make another PR to include the other ones.

@StefanoMantero
Copy link

That was intentional, because some extensions are only build after the release of PHP8.2 and could not be installed at that time. It seems like right now only the extension php8.2-pcov is still missing. So I will make another PR to include the other ones.

Well, thanks for the explaination! Looking forward for the PR to be merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants