check if --dirty flag is passed for pint and pass files changed as argument for pint #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@driesvints Would you be able to spare some time to go over the pull request? |
maskeynihal
force-pushed
the
support-for-flag-dirty-for-pint
branch
from
ee5c525
to
fd90281
Compare
maskeynihal
changed the title
|
No plans to add this right now. |
|
@taylorotwell , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to laravel/pint#169
Currently, when running pint from sail with
--dirtyflag, the pint doesn't work as the container is not a git repo.In this PR, I have checked if the
--dirtyargument is passed and if it's passed, the list of files changed will be passed as an argument to pint rather.Without the flag
--dirtyit works without any change.With the flag
--dirtyit will update the files only those that are modified.These are the files changed shown by
git status --short -- '**.php'In the previous script, passing
--dirtyflag make no changes in the filesNOTE⚠️
The excluding files config of
pint.jsonwill not be respected for now because pint ignores these configs when a file path argument is passed.