Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm run dev to supervisord #581

Closed
wants to merge 3 commits into from

Conversation

x7ryan
Copy link

@x7ryan x7ryan commented May 8, 2023

The first thing I do after running my alias for ./vendor/bin/sail up -d when working on a project is open up a second terminal window and run my alias for ./vendor/bin/sail npm run dev to start the Vite watcher.

It occurred to me I don't have to manually run ./vendor/bin/sail artisan serve, sail does that automatically in the background, why not do the same for npm run dev? Its just a small supervisord config, so this PR does just that making one less step to get up and running in development.

NOTE: Existing projects using sail would have to run ./vendor/bin/sail build to get the update supervisord.conf in their container image.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@x7ryan x7ryan changed the title Add npm run build to supervisord Add npm run dev to supervisord May 8, 2023
@x7ryan
Copy link
Author

x7ryan commented May 8, 2023

@taylorotwell FYI I updated a mistake in the title. Just in case you only read the title and had the wrong idea of what I was doing.

Seems I made the same mistake in the commit message too sorry, but if you look at the actual changes it is using dev NOT build. Sorry for any confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants