Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An alternate environment file so Docker compose #586

Closed
wants to merge 1 commit into from
Closed

An alternate environment file so Docker compose #586

wants to merge 1 commit into from

Conversation

vladdevops
Copy link

Hello,

I had an issue when working with a container through Sail, where the variables from .env.local were not being passed, even though the variable "APP_ENV=local" was set.

I received the following warning message: "WARN[0000] The "VAR_NAME" variable is not set. Defaulting to a blank string."

I may have been using "./vendor/bin/sail" incorrectly. Here's my "sail" file located in the root directory of my project:

#!/usr/bin/env bash

export APP_ENV=local
./vendor/bin/sail "$@"

This fix resolves the issue.

Perhaps there is another solution that doesn't involve modifying the library. I would appreciate it if you could share any alternative solutions.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants