Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ./vendor/bin to the path in Dockerfile #602

Closed
wants to merge 2 commits into from
Closed

Conversation

meditto
Copy link

@meditto meditto commented Aug 11, 2023

I added this line to Dockerfile ENV PATH "$PATH:.:./vendor/bin:./node_modules/.bin"
With the expanded PATH variable, developers can run sail shell then execute key commands, such as pest and phpstan or running artisan without prefixing it with the php keyword.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@meditto
Copy link
Author

meditto commented Aug 17, 2023

Hey @taylorotwell ,
I just wanted to give a shoutout for the awesome work you're doing in keeping Laravel top-notch for us developers. Big thanks!
Talking about the pull request, I totally get your point. Even though it's just one line, it improves the developer experience. I've been adding this line manually in my sail files, and having it by default would be super cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants