Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows (Powershell) support #666

Closed
wants to merge 1 commit into from

Conversation

WalterWoshid
Copy link
Contributor

@WalterWoshid WalterWoshid commented Feb 11, 2024

Here is a package for anyone needing this: https://github.com/WalterWoshid/laravel-sail-for-windows

Couldn't reopen #665 for some reason.

Adding the sail.ps1 script to the composer.json bin section won't work, because Composer converts it into a bash script. I have added a new publish item which copies the sail.ps1 file to the bin folder of Composer with the laravel-assets tag. This should mimick Composers binary copying.

image
image

@WalterWoshid WalterWoshid force-pushed the powershell branch 2 times, most recently from 47baec5 to 2ed0e6b Compare February 11, 2024 15:28
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@WalterWoshid
Copy link
Contributor Author

WalterWoshid commented Feb 12, 2024

Hi, thanks for the feedback, I had a feeling that the codebase was very slim, which I understand. I'd be happy to make a package out of it :)

Edit: Here is a package for anyone needing this: https://github.com/WalterWoshid/laravel-sail-for-windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants