Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MARIADB_ Environment Variable Equivalent for Mariadb #668

Closed
wants to merge 1 commit into from
Closed

Use MARIADB_ Environment Variable Equivalent for Mariadb #668

wants to merge 1 commit into from

Conversation

SamuelMwangiW
Copy link
Contributor

@SamuelMwangiW SamuelMwangiW commented Feb 15, 2024

In MariaDB, MARIADB_* environment variables have a higher preference to MYSQL_* variants.

The project only lists the MARIADB_* variants on the Docker hub page. The Knowledge Base also shows a clear bias towards MARIADB_* variants.

MYSQL_* environment variables work with MariaDB and there is no indication that this will change soon. I would therefore understand if you wish to retain MYSQL_* variants.

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@SamuelMwangiW SamuelMwangiW marked this pull request as ready for review February 15, 2024 06:51
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@SamuelMwangiW SamuelMwangiW deleted the mariadb-env-variables branch February 15, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants